From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: fx_init schedule in atomic Date: Sun, 04 May 2008 16:03:53 +0300 Message-ID: <481DB439.7040303@qumranet.com> References: <20080501164333.GJ8150@duo.random> <481ADEC0.60602@qumranet.com> <20080502151917.GM8150@duo.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net To: Andrea Arcangeli Return-path: In-Reply-To: <20080502151917.GM8150@duo.random> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > On Fri, May 02, 2008 at 12:28:32PM +0300, Avi Kivity wrote: > >> Applied, thanks. Dynamic allocation for the fpu state was introduced in >> 2.6.26-rc, right? >> > > It seems very recent, hit mainline on 30 Apr. > > Also we may want to think if there's something cheaper than fx_save to > trigger a math exception that doesn't alter the fpu state, I didn't > think much about it given it's such a slow path that's probably not > worth changing with something more complicated anyway. And bringing in > a few l1 exclusive cachelines in the cpu should allow the second > instruction to repeat faster than the first. > Oh, it's hardly performance critical. I think it is fine as is. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone