From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH 3/3] Stop dropping so many RX packets in tap
 (v2)
Date: Sun, 04 May 2008 17:53:27 -0500
Message-ID: <481E3E67.6020904@codemonkey.ws>
References: <1209932475-7042-1-git-send-email-aliguori@us.ibm.com>	<1209932475-7042-3-git-send-email-aliguori@us.ibm.com>
	<1209939229.24261.81.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net,
	Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@qumranet.com>
To: dor.laor@qumranet.com
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <1209939229.24261.81.camel@localhost.localdomain>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Dor Laor wrote:
> On Sun, 2008-05-04 at 15:21 -0500, Anthony Liguori wrote:
>   
> Patchset looks good and reduces some nasty hacks. It probably also
> improves other devices like e1000 et al.
>   

Yeah, we just need to make sure they have proper can_receive handlers.  
I took a quick look at the e1000 but it wasn't entirely obvious to me 
how RX packets get queued.  AFAICT, the e1000 can_receive handler only 
reports false when the device isn't initialized so it's likely it's 
dropping packets.

Regards,

Anthony Liguori

> Cheers,
> Dor
>
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> kvm-devel mailing list
> kvm-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone