From: Avi Kivity <avi@qumranet.com>
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Cc: kvm-devel@lists.sourceforge.net, kvm-ia64-devel@lists.sourceforge.net
Subject: Re: [PATCH] Build fix for kvm/ia64 userspace.
Date: Tue, 06 May 2008 17:41:32 +0300 [thread overview]
Message-ID: <48206E1C.4040102@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC01228C71@pdsmsx415.ccr.corp.intel.com>
Zhang, Xiantao wrote:
> Hi, Avi
> This patch should go into RC1, otherwise it will block kvm/ia64
> userspace build.
>
> diff --git a/include/asm-ia64/kvm.h b/include/asm-ia64/kvm.h
> index eb2d355..62b5fad 100644
> --- a/include/asm-ia64/kvm.h
> +++ b/include/asm-ia64/kvm.h
> @@ -22,7 +22,12 @@
> */
>
> #include <asm/types.h>
> +
> +#ifdef __KERNEL__
> #include <asm/fpu.h>
> +#else
> +#include <signal.h>
> +#endif
>
Fishy. A kernel header including a userspace header?
Maybe you need to include <linux/signal.h> unconditionally?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-05-06 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 5:12 [PATCH] Build fix for kvm/ia64 userspace Zhang, Xiantao
2008-05-06 14:41 ` Avi Kivity [this message]
2008-05-07 6:23 ` Zhang, Xiantao
2008-05-07 8:00 ` Avi Kivity
2008-05-07 10:30 ` Zhang, Xiantao
2008-05-07 11:07 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48206E1C.4040102@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=kvm-ia64-devel@lists.sourceforge.net \
--cc=xiantao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox