From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 1/4] Replace SIGUSR1 in io-thread with eventfd() (v2) Date: Tue, 06 May 2008 14:44:38 -0500 Message-ID: <4820B526.3020406@us.ibm.com> References: <1209995235-32544-1-git-send-email-aliguori@us.ibm.com> <20080506194609.GA18171@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel@lists.sourceforge.net, Avi Kivity To: Marcelo Tosatti Return-path: In-Reply-To: <20080506194609.GA18171@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > Looks good (the whole series). > > Needs some good testing of course... Have you tested migration/loadvm? > No, but I will before resubmitting (which should be sometime tomorrow). Regards, Anthony Liguori > On Mon, May 05, 2008 at 08:47:12AM -0500, Anthony Liguori wrote: > >> It's a little odd to use signals to raise a notification on a file descriptor >> when we can just work directly with a file descriptor instead. This patch >> converts the SIGUSR1 based notification in the io-thread to instead use an >> eventfd file descriptor. If eventfd isn't available, we use a pipe() instead. >> >> The benefit of using eventfd is that multiple notifications will be batched >> into a signal IO event. >> >> Signed-off-by: Anthony Liguori >> ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone