Re: [PATCH] Build fix for kvm/ia64 userspace.

[Avi Kivity <avi@qumranet.com>]

Zhang, Xiantao wrote:
>>>  #include <asm/types.h>
>>> +
>>> +#ifdef __KERNEL__
>>>  #include <asm/fpu.h>
>>> +#else
>>> +#include <signal.h>
>>> +#endif
>>>
>>>       
>> Fishy.  A kernel header including a userspace header?
>>
>> Maybe you need to include <linux/signal.h> unconditionally?
>>     
> Hi, Avi 
> 	You know, kvm.h is shared by userspace and kernel. But
> unfortunately, the usersapce header files have redefinition for one
> strucutre (structure ia64_fpreg) {One in asm/fpu.h and the other one in
> bits/sigcontext}, maybe a bug here. 
> 	 Therefore, if userspace code includes fpu.h and sigcontext.h in
> one source file, it will complain the redefinition.  Do you have good
> idea to cope with this issue ?

One way would be to define a new kvm_ia64_fpreg and use that.  Seems 
that the standard ia64_fpreg is unusable in userspace due to the issue 
you mentioned.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone