From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Build fix for kvm/ia64 userspace.
Date: Wed, 07 May 2008 11:00:02 +0300
Message-ID: <48216182.8040303@qumranet.com>
References: <42DFA526FC41B1429CE7279EF83C6BDC01228C71@pdsmsx415.ccr.corp.intel.com>
	<48206E1C.4040102@qumranet.com>
	<42DFA526FC41B1429CE7279EF83C6BDC012295A4@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net, Tony Luck <tony.luck@intel.com>,
	kvm-ia64-devel@lists.sourceforge.net
To: "Zhang, Xiantao" <xiantao.zhang@intel.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC012295A4@pdsmsx415.ccr.corp.intel.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Zhang, Xiantao wrote:
>>>  #include <asm/types.h>
>>> +
>>> +#ifdef __KERNEL__
>>>  #include <asm/fpu.h>
>>> +#else
>>> +#include <signal.h>
>>> +#endif
>>>
>>>       
>> Fishy.  A kernel header including a userspace header?
>>
>> Maybe you need to include <linux/signal.h> unconditionally?
>>     
> Hi, Avi 
> 	You know, kvm.h is shared by userspace and kernel. But
> unfortunately, the usersapce header files have redefinition for one
> strucutre (structure ia64_fpreg) {One in asm/fpu.h and the other one in
> bits/sigcontext}, maybe a bug here. 
> 	 Therefore, if userspace code includes fpu.h and sigcontext.h in
> one source file, it will complain the redefinition.  Do you have good
> idea to cope with this issue ?

One way would be to define a new kvm_ia64_fpreg and use that.  Seems 
that the standard ia64_fpreg is unusable in userspace due to the issue 
you mentioned.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone