From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] [ACPI] Enable direct GSI mapping for APIC
Date: Wed, 07 May 2008 13:20:46 +0300
Message-ID: <4821827E.1090304@qumranet.com>
References: <481B2B5C.50602@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <481B2B5C.50602@suse.de>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Alexander Graf wrote:
> Hi,
>
> in the DSDT there are two different ways of defining, how an interrupt 
> is supposed to be routed. Currently we are using the LNKA - LNKD 
> method, which afaict is for legacy support.
> The other method is to directly tell the Operating System, which APIC 
> pin the device is attached to. We can get that information from the 
> very same entry, the LNKA to LNKD pseudo devices receive it.
>
> For now this does not give any obvious improvement. It does leave room 
> for more advanced mappings, with several IOAPICs that can handle more 
> devices separately. This might help when we have a lot of devices, as 
> currently all devices sit on two interrupt lanes.
>
> More importantly (for me) though, is that Darwin enables the APIC mode 
> unconditionally, so it won't easily run in legacy mode.
>

Please properly signoff on patches.

Also:

> +                // PCI Slot 8
> +                Package() {0x0008ffff, 0, 0, ARQ3},
> +                Package() {0x0008ffff, 1, 0, ARQ0},
> +                Package() {0x0008ffff, 2, 0, ARQ1},
> +                Package() {0x0008ffff, 3, 0, ARQ2},
> +
> +                // PCI Slot 9
> +                Package() {0x0008ffff, 0, 0, ARQ0},
> +                Package() {0x0008ffff, 1, 0, ARQ1},
> +                Package() {0x0008ffff, 2, 0, ARQ2},
> +                Package() {0x0008ffff, 3, 0, ARQ3},
> +

Slot 9 uses the same addresses as slot 8.   Similarly for slot 25. 
(found by Marcelo for the code which was the source for this copy-paste)

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone