From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] Fix e1000 can_receive handler
Date: Thu, 08 May 2008 20:21:04 +0300
Message-ID: <48233680.50401@qumranet.com>
References: <1210196458-17069-1-git-send-email-aliguori@us.ibm.com>
	<20080508132646.GA27727@volta.aurel32.net>
	<4823081D.5010108@us.ibm.com> <4823323A.8040809@qumranet.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel@lists.sourceforge.net,
	Aurelien Jarno <aurelien@aurel32.net>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-devel-bounces@lists.sourceforge.net>
In-Reply-To: <4823323A.8040809@qumranet.com>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel@lists.sourceforge.net>
List-Help: <mailto:kvm-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request@lists.sourceforge.net?subject=subscribe>
Sender: kvm-devel-bounces@lists.sourceforge.net
Errors-To: kvm-devel-bounces@lists.sourceforge.net
List-Id: kvm.vger.kernel.org

Avi Kivity wrote:
>
> Note that flow control still makes sense since it allows us to buffer 
> some packets if the guest is scheduled out.  But we can't use it as 
> the primary mechanism since it won't exist with multiqueue NICs (where 
> the virtio descriptors are fed to driver).
>

... are fed to the hardware, I meant.

And to clarify further, I do think the patch is correct, but that virtio 
should be able to work well without it under ordinary circumstances.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone