From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: KVM: kvm_vcpu_block task state race
Date: Sun, 11 May 2008 17:24:37 +0300 [thread overview]
Message-ID: <482701A5.30509@qumranet.com> (raw)
In-Reply-To: <20080509192742.GA13685@dmt>
Marcelo Tosatti wrote:
> On Fri, May 09, 2008 at 04:22:08PM -0300, Marcelo Tosatti wrote:
>
>> For things like register dumps I don't believe its worthwhile. Much
>> simpler to stop the vcpu with SIG_IPI, retrieve registers, and run it
>> again (now that you mention the busy-spin, it is broken right now, if a
>> vcpu is spinning without exiting to userspace).
>>
>
> ... which is what Jan's gdb/monitor patch does.
>
We'd better change it. Suppose your vcpu is spinning, and you want to
find out why?
One nice thing would be to add an on_vcpu(void (*func)(void *data), void
*data), so that people don't have to open-code it for things like this.
I tried to do this once, but backed off due to the mess that qemu-kvm
threading was at the time. I think it's much better off now.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
next prev parent reply other threads:[~2008-05-11 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 22:47 KVM: kvm_vcpu_block task state race Marcelo Tosatti
2008-05-09 7:40 ` Avi Kivity
2008-05-09 14:21 ` Marcelo Tosatti
2008-05-09 15:09 ` Avi Kivity
2008-05-09 19:22 ` Marcelo Tosatti
2008-05-09 19:27 ` Marcelo Tosatti
2008-05-11 14:24 ` Avi Kivity [this message]
2008-05-11 14:26 ` Avi Kivity
2008-05-14 5:21 ` Marcelo Tosatti
2008-05-14 7:55 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=482701A5.30509@qumranet.com \
--to=avi@qumranet.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm-devel@lists.sourceforge.net \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox