From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM: kvm_vcpu_block task state race Date: Sun, 11 May 2008 17:24:37 +0300 Message-ID: <482701A5.30509@qumranet.com> References: <20080508224701.GA6175@dmt> <4823FFFF.3040005@qumranet.com> <20080509142101.GA11591@dmt> <48246935.50603@qumranet.com> <20080509192208.GA13579@dmt> <20080509192742.GA13685@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Jan Kiszka To: Marcelo Tosatti Return-path: In-Reply-To: <20080509192742.GA13685@dmt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Marcelo Tosatti wrote: > On Fri, May 09, 2008 at 04:22:08PM -0300, Marcelo Tosatti wrote: > >> For things like register dumps I don't believe its worthwhile. Much >> simpler to stop the vcpu with SIG_IPI, retrieve registers, and run it >> again (now that you mention the busy-spin, it is broken right now, if a >> vcpu is spinning without exiting to userspace). >> > > ... which is what Jan's gdb/monitor patch does. > We'd better change it. Suppose your vcpu is spinning, and you want to find out why? One nice thing would be to add an on_vcpu(void (*func)(void *data), void *data), so that people don't have to open-code it for things like this. I tried to do this once, but backed off due to the mess that qemu-kvm threading was at the time. I think it's much better off now. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone