From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] qemu-kvm: Fix guest resetting v2 Date: Mon, 12 May 2008 14:29:19 +0300 Message-ID: <48282A0F.3000908@qumranet.com> References: <482820C3.3050407@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Marcelo Tosatti To: Jan Kiszka Return-path: In-Reply-To: <482820C3.3050407@web.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org Jan Kiszka wrote: > Resetting guests used to be racy, deadlock-prone, or simply broken (for > SMP). This patch fixes the issues, following Marcelo's suggestion to > consolidate the reset activity in the I/O thread. All vcpus are cleanly > stopped before the emulated hardware is reset, and kvm_arch_cpu_reset is > introduced and invoked to ensure that non-boot cpus are put into the > right state on x86. Note that other arch may need to look into this > service as well to get SMP reset right. > > hmm. This means that reset is executed asynchronously of the calling cpu. Well, in a real machine a keyboard controller reset is asynchronous as well, so I guess that's not an issue. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone