From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 2/2] qemu-kvm: Fix guest resetting v2 Date: Mon, 12 May 2008 13:38:58 +0200 Message-ID: <48282C52.7000706@web.de> References: <482820C3.3050407@web.de> <48282A0F.3000908@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1292718106==" Cc: kvm-devel , Marcelo Tosatti To: Avi Kivity Return-path: In-Reply-To: <48282A0F.3000908@qumranet.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces@lists.sourceforge.net Errors-To: kvm-devel-bounces@lists.sourceforge.net List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1292718106== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigB317F9FD58C1B89E19797E5F" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigB317F9FD58C1B89E19797E5F Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Jan Kiszka wrote: >> Resetting guests used to be racy, deadlock-prone, or simply broken (fo= r >> SMP). This patch fixes the issues, following Marcelo's suggestion to >> consolidate the reset activity in the I/O thread. All vcpus are cleanl= y >> stopped before the emulated hardware is reset, and kvm_arch_cpu_reset = is >> introduced and invoked to ensure that non-boot cpus are put into the >> right state on x86. Note that other arch may need to look into this >> service as well to get SMP reset right. >> >> =20 >=20 > hmm. This means that reset is executed asynchronously of the calling c= pu. Nope, the calling cpu is put in stopped state after informing the I/O thread about the reset request. We just cannot control when the request is handled /wrt to other cpus, but that's not different from real life I guess. Jan --------------enigB317F9FD58C1B89E19797E5F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFIKCxSniDOoMHTA+kRAkWMAJ9KmcAeBoRsOKk8RkH2YjLn4OtqLACbBMcb AQ5U3kpdHlBVriY41iwk0iQ= =731b -----END PGP SIGNATURE----- --------------enigB317F9FD58C1B89E19797E5F-- --===============1292718106== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone --===============1292718106== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1292718106==--