From: David Hildenbrand <david@redhat.com>
To: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: Pierre Morel <pmorel@linux.ibm.com>,
kvm@vger.kernel.org, frankja@linux.ibm.com, thuth@redhat.com,
cohuck@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2] s390x: fixing I/O memory allocation
Date: Thu, 11 Nov 2021 11:39:19 +0100 [thread overview]
Message-ID: <4828bb9d-6bfe-a9da-51a4-77f4e78f7556@redhat.com> (raw)
In-Reply-To: <20211111112806.50e4d22a@p-imbrenda>
On 11.11.21 11:28, Claudio Imbrenda wrote:
> On Thu, 11 Nov 2021 11:14:53 +0100
> David Hildenbrand <david@redhat.com> wrote:
>
>> On 11.11.21 11:01, Pierre Morel wrote:
>>> The allocator allocate pages it follows the size must be rounded
>>> to pages before the allocation.
>>>
>>> Fixes: b0fe3988 "s390x: define UV compatible I/O allocation"
>>>
>>
>> What's the symptom of this? A failing test? Or is this just a pro-activ fix?
>
> if size < PAGE_SIZE then we would allocate 0, and in general we are
> rounding down instead of up, which is obviously wrong.
>
I know, but is this fixing a failing test or is this just a pro-activ fix?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-11-11 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 10:01 [kvm-unit-tests PATCH v2] s390x: fixing I/O memory allocation Pierre Morel
2021-11-11 10:14 ` David Hildenbrand
2021-11-11 10:28 ` Claudio Imbrenda
2021-11-11 10:39 ` David Hildenbrand [this message]
2021-11-11 11:55 ` Pierre Morel
2021-11-11 15:10 ` Janosch Frank
-- strict thread matches above, loose matches on Subject: below --
2021-11-16 12:26 Pierre Morel
2021-11-16 12:27 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4828bb9d-6bfe-a9da-51a4-77f4e78f7556@redhat.com \
--to=david@redhat.com \
--cc=cohuck@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pmorel@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox