public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Remove unused get_bios_map
@ 2008-05-15 13:05 Jan Kiszka
  2008-05-19 10:19 ` [kvm-devel] " Avi Kivity
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Kiszka @ 2008-05-15 13:05 UTC (permalink / raw)
  To: kvm-devel

Dead code since it was introduced. Is it planned to use it in the near
future? Then I would suggest to put it under #if 0 for now. Otherwise,
please pick up this patch.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 qemu/kvm-tpr-opt.c |   13 -------------
 1 file changed, 13 deletions(-)

Index: b/qemu/kvm-tpr-opt.c
===================================================================
--- a/qemu/kvm-tpr-opt.c
+++ b/qemu/kvm-tpr-opt.c
@@ -83,19 +83,6 @@ static void write_byte_virt(CPUState *en
     stb_phys(map_addr(&sregs, virt, NULL), b);
 }
 
-static uint32_t get_bios_map(CPUState *env, unsigned *perms)
-{
-    uint32_t v;
-    struct kvm_sregs sregs;
-
-    kvm_get_sregs(kvm_context, env->cpu_index, &sregs);
-
-    for (v = -4096u; v != 0; v -= 4096)
-	if (map_addr(&sregs, v, perms) == 0xe0000)
-	    return v;
-    return -1u;
-}
-
 struct vapic_bios {
     char signature[8];
     uint32_t virt_base;

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft 
Defy all challenges. Microsoft(R) Visual Studio 2008. 
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [kvm-devel] [PATCH] Remove unused get_bios_map
  2008-05-15 13:05 [PATCH] Remove unused get_bios_map Jan Kiszka
@ 2008-05-19 10:19 ` Avi Kivity
  0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2008-05-19 10:19 UTC (permalink / raw)
  To: Jan Kiszka; +Cc: kvm-devel

Jan Kiszka wrote:
> Dead code since it was introduced. Is it planned to use it in the near
> future? Then I would suggest to put it under #if 0 for now. Otherwise,
> please pick up this patch.
>   

Applied, thanks.


-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-19 10:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-15 13:05 [PATCH] Remove unused get_bios_map Jan Kiszka
2008-05-19 10:19 ` [kvm-devel] " Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox