From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian Date: Tue, 20 May 2008 19:25:43 +0300 Message-ID: <4832FB87.9020501@qumranet.com> References: <08DF4D958216244799FC84F3514D70F0015B1B58@pdsmsx415.ccr.corp.intel.com> <200805141637.03442.hollisb@us.ibm.com> <08DF4D958216244799FC84F3514D70F00164BF05@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Tan, Li" Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:40700 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753540AbYETQZo (ORCPT ); Tue, 20 May 2008 12:25:44 -0400 In-Reply-To: <08DF4D958216244799FC84F3514D70F00164BF05@pdsmsx415.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: Tan, Li wrote: > From 63283d32ad5faf0845fa0358fd71d119f4dc0e3d Mon Sep 17 00:00:00 2001 > From: Tan Li > Date: Mon, 19 May 2008 17:18:54 +0800 > Subject: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for > supporting big_endian > > Currently kvmtrace is not portable. This will prevent from copying a > trace file from big-endian target to little-endian workstation for > analysis. > > In the patch, kernel outputs metadata containing a magic number to trace > log. > > diff --git a/include/linux/kvm.h b/include/linux/kvm.h > index a281afe..ca08cb1 100644 > --- a/include/linux/kvm.h > +++ b/include/linux/kvm.h > @@ -294,14 +294,14 @@ struct kvm_trace_rec { > __u32 vcpu_id; > union { > struct { > - __u32 cycle_lo, cycle_hi; > + __u64 cycle_u64; > __u32 extra_u32[KVM_TRC_EXTRA_MAX]; > } cycle; > For this bit, you'll need to change 'II' to 'L' in the format, no? -- error compiling committee.c: too many arguments to function