From: Chris Lalancette <clalance@redhat.com>
To: kvm@vger.kernel.org
Subject: [PATCH]: Fix crash in virtio_blk during modprobe ; rmmod ; modprobe
Date: Wed, 21 May 2008 14:45:31 +0200 [thread overview]
Message-ID: <4834196B.3010704@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 209 bytes --]
Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash; this
was basically because we weren't doing "del_gendisk()" in the remove path.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
[-- Attachment #2: virtio-blk-rmmod-crash.patch --]
[-- Type: text/x-patch, Size: 734 bytes --]
commit 9ae82ccb26be0155ad81b2630090e85639a0dc56
Author: Chris Lalancette <clalance@redhat.com>
Date: Fri May 16 15:31:06 2008 -0400
Fix a modprobe virtio_blk ; rmmod virtio_blk ; modprobe virtio_blk crash;
this was basically because we weren't doing "del_gendisk()" in the remove
path.
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 4962e62..c678ac5 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -294,6 +294,7 @@ static void virtblk_remove(struct virtio_device *vdev)
vdev->config->reset(vdev);
blk_cleanup_queue(vblk->disk->queue);
+ del_gendisk(vblk->disk);
put_disk(vblk->disk);
unregister_blkdev(major, "virtblk");
mempool_destroy(vblk->pool);
reply other threads:[~2008-05-21 12:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4834196B.3010704@redhat.com \
--to=clalance@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox