From: Avi Kivity <avi@qumranet.com>
To: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>
Cc: kvm@vger.kernel.org, Anthony Liguori <anthony@codemonkey.ws>,
Mohammed Gamal <m.gamal005@gmail.com>,
"Kamble, Nitin A" <nitin.a.kamble@intel.com>,
Alexander Graf <alex@csgraf.de>,
Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [RFC] Patch - Big real mode emulation
Date: Wed, 21 May 2008 17:10:52 +0300 [thread overview]
Message-ID: <48342D6C.3040200@qumranet.com> (raw)
In-Reply-To: <48342AD2.40406@qumranet.com>
Avi Kivity wrote:
>> @@ -1342,6 +1346,10 @@ special_insn:
>> switch (c->b) {
>> case 0x00 ... 0x05:
>> add: /* add */
>> + if ((c->d & ModRM) && c->modrm_mod == 3) {
>> + c->dst.bytes = (c->d & ByteOp) ? 1 : c->op_bytes;
>> + c->dst.ptr = decode_register(c->modrm_rm, c->regs, c->d & ByteOp);
>> + }
>
> This is not specific to the add instruction. We really need to switch
> decode_modrm() to decode into a struct operand.
>
Btw, I see that the decoder already handles this (see DstMem decoding
for the case where mod == 3). Is this code really needed now?
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-05-21 14:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 9:34 [RFC] Patch - Big real mode emulation Guillaume Thouvenin
2008-05-21 13:59 ` Avi Kivity
2008-05-21 14:10 ` Avi Kivity [this message]
2008-05-22 8:55 ` Guillaume Thouvenin
2008-05-21 17:19 ` Marcelo Tosatti
2008-05-21 15:32 ` Mohammed Gamal
2008-05-21 16:18 ` Marcelo Tosatti
2008-05-22 9:02 ` Guillaume Thouvenin
2008-05-21 23:18 ` Kamble, Nitin A
2008-05-22 22:52 ` Mohammed Gamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48342D6C.3040200@qumranet.com \
--to=avi@qumranet.com \
--cc=alex@csgraf.de \
--cc=anthony@codemonkey.ws \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
--cc=nitin.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox