From: Avi Kivity <avi@qumranet.com>
To: "Tan, Li" <li.tan@intel.com>
Cc: kvm@vger.kernel.org
Subject: Re: FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian
Date: Wed, 21 May 2008 19:21:14 +0300 [thread overview]
Message-ID: <48344BFA.4060905@qumranet.com> (raw)
In-Reply-To: <08DF4D958216244799FC84F3514D70F00164C4BB@pdsmsx415.ccr.corp.intel.com>
Tan, Li wrote:
>> @@ -294,14 +294,14 @@ struct kvm_trace_rec {
>> __u32 vcpu_id;
>> union {
>> struct {
>> - __u32 cycle_lo, cycle_hi;
>> + __u64 cycle_u64;
>> __u32 extra_u32[KVM_TRC_EXTRA_MAX];
>> } cycle;
>>
>>
>
> For this bit, you'll need to change 'II' to 'L' in the format, no?
>
>
> [tan] it should be "Q", not "L", according to
> http://docs.python.org/lib/module-struct.html
>
> in kvmtrace_format, it's already like:
> TSCREC = "Q"
Oh, I didn't notice. Sorry.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-05-21 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-21 7:50 FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian Tan, Li
2008-05-21 16:21 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48344BFA.4060905@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=li.tan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox