From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for
 supporting big_endian
Date: Wed, 21 May 2008 19:21:14 +0300
Message-ID: <48344BFA.4060905@qumranet.com>
References: <08DF4D958216244799FC84F3514D70F00164C4BB@pdsmsx415.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: "Tan, Li" <li.tan@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:52321
	"EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757364AbYEUQVQ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 21 May 2008 12:21:16 -0400
In-Reply-To: <08DF4D958216244799FC84F3514D70F00164C4BB@pdsmsx415.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Tan, Li wrote:
>> @@ -294,14 +294,14 @@ struct kvm_trace_rec {
>>  	__u32 vcpu_id;
>>  	union {
>>  		struct {
>> -			__u32 cycle_lo, cycle_hi;
>> +			__u64 cycle_u64;
>>  			__u32 extra_u32[KVM_TRC_EXTRA_MAX];
>>  		} cycle;
>>   
>>     
>
> For this bit, you'll need to change 'II' to 'L' in the format, no?
>
>   
> [tan] it should be "Q", not "L", according to 
> http://docs.python.org/lib/module-struct.html
>
> in kvmtrace_format, it's already like:
>  TSCREC = "Q"


Oh, I didn't notice. Sorry.

-- 
error compiling committee.c: too many arguments to function