FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian

FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian

[Tan, Li]

-----Original Message-----
From: Avi Kivity [mailto:avi@qumranet.com] 
Sent: 2008年5月21日 0:26
To: Tan, Li
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian

Tan, Li wrote:
> From 63283d32ad5faf0845fa0358fd71d119f4dc0e3d Mon Sep 17 00:00:00 2001
> From: Tan Li <li.tan@intel.com>
> Date: Mon, 19 May 2008 17:18:54 +0800
> Subject: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for
> supporting big_endian
>
> Currently kvmtrace is not portable. This will prevent from copying a
> trace file from big-endian target to little-endian workstation for
> analysis.
>
> In the patch, kernel outputs metadata containing a magic number to trace
> log.
>
> diff --git a/include/linux/kvm.h b/include/linux/kvm.h
> index a281afe..ca08cb1 100644
> --- a/include/linux/kvm.h
> +++ b/include/linux/kvm.h
> @@ -294,14 +294,14 @@ struct kvm_trace_rec {
>  	__u32 vcpu_id;
>  	union {
>  		struct {
> -			__u32 cycle_lo, cycle_hi;
> +			__u64 cycle_u64;
>  			__u32 extra_u32[KVM_TRC_EXTRA_MAX];
>  		} cycle;
>   

For this bit, you'll need to change 'II' to 'L' in the format, no?

-- 
error compiling committee.c: too many arguments to function

[tan] it should be "Q", not "L", according to 
http://docs.python.org/lib/module-struct.html

in kvmtrace_format, it's already like:
 TSCREC = "Q"

Re: FW: [PATCH] [RFC][PATCH] kvm: kvmtrace: kvm_trace in kernel for supporting big_endian

[Avi Kivity]

Tan, Li wrote:
>> @@ -294,14 +294,14 @@ struct kvm_trace_rec {
>>  	__u32 vcpu_id;
>>  	union {
>>  		struct {
>> -			__u32 cycle_lo, cycle_hi;
>> +			__u64 cycle_u64;
>>  			__u32 extra_u32[KVM_TRC_EXTRA_MAX];
>>  		} cycle;
>>   
>>     
>
> For this bit, you'll need to change 'II' to 'L' in the format, no?
>
>   
> [tan] it should be "Q", not "L", according to 
> http://docs.python.org/lib/module-struct.html
>
> in kvmtrace_format, it's already like:
>  TSCREC = "Q"


Oh, I didn't notice. Sorry.

-- 
error compiling committee.c: too many arguments to function