Re: [Fwd: [PATCH]: Fix silly output for virtio devices in /proc/interrupts]

[Chris Lalancette <clalance@redhat.com>]

Rusty Russell wrote:
> On Wednesday 21 May 2008 23:13:05 Chris Lalancette wrote:
>> Author: Chris Lalancette <clalance@redhat.com>
>> Date:   Thu May 15 09:04:55 2008 -0400
>>
>>     register_virtio_device was doing something silly, in that it was
>> overwriting what the calling driver stuck into .bus_id" for the name.  This
>> caused problems in the output of /proc/interrupts, since when you
>> request_irq(), it doesn't actually copy the devname you pass in but just
>> stores a pointer to the data.  The fix is to just not have
>> register_virtio_device do anything with the bus_id, and assume the higher
>> level driver set it up properly.
> 
> OK, but only one higher-level driver will set it up properly: kvm.  Neither
> lguest nor s/390 do this, and as a result, they fail to register *any*
> devices.

Ah, OK.  Alternatively, we could do:

snprintf(bus_id, BUS_ID_SIZE, "virtio%d", index)

in register_virtio_device(), and just fix the one user who does it themselves
(kvm) to not duplicate the work.

Either way is fine with me.

Chris Lalancette