From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [kvm-devel] [RFC][PATCH 2/4] kvm: Arch-specifc KVM_EXIT_DEBUG payload Date: Thu, 22 May 2008 15:27:07 +0200 Message-ID: <483574AB.4000100@web.de> References: <482D9198.7040801@web.de> <482DAFF6.3050403@web.de> <483446E8.1020605@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigD4748DED372512F398DBCAD0" Cc: kvm-devel , Hollis Blanchard To: Avi Kivity Return-path: Received: from fmmailgate03.web.de ([217.72.192.234]:37897 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932094AbYEVN1K (ORCPT ); Thu, 22 May 2008 09:27:10 -0400 In-Reply-To: <483446E8.1020605@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD4748DED372512F398DBCAD0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Jan Kiszka wrote: >> This adds an arch field to kvm_run.debug, the payload that is returned= >> to user space on KVM_EXIT_DEBUG guest exits. For x86, this field is no= w >> supposed to report the precise debug exception (#DB or #BP) and the >> current state of the debug registers (the latter is not yet >> implemented). >> >> Index: b/include/asm-x86/kvm.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- a/include/asm-x86/kvm.h >> +++ b/include/asm-x86/kvm.h >> @@ -230,4 +230,9 @@ struct kvm_pit_state { >> #define KVM_TRC_APIC_ACCESS (KVM_TRC_HANDLER + 0x14) >> #define KVM_TRC_TDP_FAULT (KVM_TRC_HANDLER + 0x15) >> =20 >> +struct kvm_debug_exit_arch { >> + __u32 exception; >> + __u64 dr[8]; >> +}; >> + >> =20 >=20 > Need empty structures for non-x86. >=20 > Need a KVM_CAP_ to indicate presence of this feature. Have all this in patch already, but need time to finish it, test it, and roll it out. There are two usability issues I would like to resolve first (to see if that has impact on the kernel-user interface), see following posts. Jan --------------enigD4748DED372512F398DBCAD0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4-svn0 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iD8DBQFINXSrniDOoMHTA+kRAkfgAJ9aEpdbAXqFOvzI6m1D1HvrQMjAbwCggZKu nWlen7CdDdYohg1y7wbMal0= =Kg1t -----END PGP SIGNATURE----- --------------enigD4748DED372512F398DBCAD0--