public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Jerone Young <jyoung5@us.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] [RFC] Fix for kvm qemu to return control to gdb stub on   breakpoints
Date: Thu, 22 May 2008 18:43:08 +0200	[thread overview]
Message-ID: <4835A29C.2090407@web.de> (raw)
In-Reply-To: <5efefbab7b0f97c983a1.1211473308@thinkpadL>

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Jerone Young wrote:
> 1 file changed, 2 insertions(+)
> qemu/qemu-kvm.c |    2 ++
> 
> 
> Currently breakpoints do not fully work for x86 or any other arch with kvm enable qemu. Control is not being returned by to the gdb stub. This patch add back this ability to return control to the gdb stub when a debug interrupt is hit.
> 
> This is in the io thread so it's best to get comments on this. Is it in the best place? Should more be done here?
> 
> Signed-off-by: Jerone Young <jyoung5@us.ibm.com>
> 
> diff --git a/qemu/qemu-kvm.c b/qemu/qemu-kvm.c
> --- a/qemu/qemu-kvm.c
> +++ b/qemu/qemu-kvm.c
> @@ -352,6 +352,8 @@ static int kvm_main_loop_cpu(CPUState *e
>  	    update_regs_for_init(env);
>  	if (!(env->hflags & HF_HALTED_MASK) && !info->init)
>  	    kvm_cpu_exec(env);
> +	if (env->exception_index == EXCP_DEBUG)
> +	    vm_stop(EXCP_DEBUG);

This isn't enough, please see

	http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/17660

and the rest of that series - just RFC, but already usable.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

  reply	other threads:[~2008-05-22 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 16:21 [PATCH] [RFC] Fix for kvm qemu to return control to gdb stub on breakpoints Jerone Young
2008-05-22 16:43 ` Jan Kiszka [this message]
2008-05-22 18:00   ` Anthony Liguori
2008-05-22 19:04     ` Jan Kiszka
2008-05-22 18:10   ` Jerone Young
2008-05-22 19:04     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4835A29C.2090407@web.de \
    --to=jan.kiszka@web.de \
    --cc=jyoung5@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox