From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 3/4] QEMU/KVM: non-virtualized ACPI PMTimer support Date: Mon, 26 May 2008 11:23:15 +0300 Message-ID: <483A7373.2080503@qumranet.com> References: <20080524234342.983197667@localhost.localdomain> <20080525000036.645310064@localhost.localdomain> <48393D32.5050604@qumranet.com> <20080525173942.GA16793@dmt> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , kvm-devel To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:27057 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbYEZIXR (ORCPT ); Mon, 26 May 2008 04:23:17 -0400 In-Reply-To: <20080525173942.GA16793@dmt> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > On Sun, May 25, 2008 at 01:19:30PM +0300, Avi Kivity wrote: > >> Marcelo Tosatti wrote: >> >>> QEMU support for direct pmtimer reads. Hopefully its safe, since its a >>> read-only register ? >>> >>> >> ISTR that pmtimer can be either 24 bit or 32 bit. Can this cause a problem? >> > > Don't think so, since QEMU/KVM reports a 24-bit timer (tmr_val_ext field > of fadt is zero). If the host has a 32-bit timer, the higher bits are > ignored, and TMR_OF is emulated. > Linux seems to mask the high bits properly, yes. Hopefully other OSes do too. -- error compiling committee.c: too many arguments to function