From: Avi Kivity <avi@qumranet.com>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH 0/5] kvm: Batch writes to MMIO
Date: Mon, 26 May 2008 15:00:03 +0300 [thread overview]
Message-ID: <483AA643.3040400@qumranet.com> (raw)
In-Reply-To: <1211532607137-git-send-email-Laurent.Vivier@bull.net>
Laurent Vivier wrote:
> When kernel has to send MMIO writes to userspace, it stores them
> in memory until it has to pass the hand to userspace for another
> reason. This avoids to have too many context switches on operations
> that can wait.
>
>
Looks good. The only issue I see is inconsistent naming. Sometimes you
use delayed_mmio, sometimes batched_mmio, and there's a way-too-generic
kvm_batch. Please stick to a single name throughout the code.
> VGA text scroll
> host_state_reload 13280568 (6:15) 3608362 (4:42) -73% (-25%)
This is probably better addressed by allowing the guest to write
directly to VRAM, like in the graphic modes.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-05-26 12:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 8:50 [PATCH 0/5] kvm: Batch writes to MMIO Laurent Vivier
2008-05-23 8:50 ` [PATCH 1/5] kvm_io_device: extend in_range() to manage len and write attribute Laurent Vivier
2008-05-23 8:50 ` [PATCH 2/5] Add delayed MMIO support (common part) Laurent Vivier
2008-05-23 8:50 ` [PATCH 3/5] Add delayed MMIO support (x86 part) Laurent Vivier
2008-05-23 8:50 ` [PATCH 4/5] Add delayed MMIO support (powerpc part) Laurent Vivier
2008-05-23 8:50 ` [PATCH 5/5] Add delayed MMIO support (ia64 part) Laurent Vivier
2008-05-26 12:00 ` Avi Kivity [this message]
2008-05-26 12:10 ` [PATCH 0/5] kvm: Batch writes to MMIO Laurent Vivier
2008-05-26 13:43 ` Avi Kivity
2008-05-26 14:20 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2008-05-30 14:05 Laurent Vivier
2008-06-04 15:13 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483AA643.3040400@qumranet.com \
--to=avi@qumranet.com \
--cc=Laurent.Vivier@bull.net \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox