From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/5] kvm: Batch writes to MMIO Date: Mon, 26 May 2008 15:00:03 +0300 Message-ID: <483AA643.3040400@qumranet.com> References: <1211532607137-git-send-email-Laurent.Vivier@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Laurent Vivier Return-path: Received: from il.qumranet.com ([212.179.150.194]:55251 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbYEZMAE (ORCPT ); Mon, 26 May 2008 08:00:04 -0400 In-Reply-To: <1211532607137-git-send-email-Laurent.Vivier@bull.net> Sender: kvm-owner@vger.kernel.org List-ID: Laurent Vivier wrote: > When kernel has to send MMIO writes to userspace, it stores them > in memory until it has to pass the hand to userspace for another > reason. This avoids to have too many context switches on operations > that can wait. > > Looks good. The only issue I see is inconsistent naming. Sometimes you use delayed_mmio, sometimes batched_mmio, and there's a way-too-generic kvm_batch. Please stick to a single name throughout the code. > VGA text scroll > host_state_reload 13280568 (6:15) 3608362 (4:42) -73% (-25%) This is probably better addressed by allowing the guest to write directly to VRAM, like in the graphic modes. -- error compiling committee.c: too many arguments to function