Re: [PATCH 0/11] Rework guest debug interface / x86 debug register support -v2

Avi Kivity
2008-05-27T09:50:21Z

Jan Kiszka wrote:
> Hi,
>
> here comes the full series of patches to fix and enhance debugging
> support of KVM. After completing hardware breakpoint support and
> reorganizing the patches, I felt like I should post them all in a single
> series, because my queue became quite long and potentially confusing in
> the meantime.
>
> The major changes or this revision are full hardware-assisted guest
> debugging and a lot of refactoring on the userspace side. The latter was
> motivated by an increasing inconsistency regarding which arch-specific
> part should be handled in libkvm and which by qemu. I decided to push
> everything into qemu, keeping the lib small (and easier to overcome one
> day :->).
>
> When I was trying to test the hardware breakpoint/watchpoint support
> with gdb, the first result with quite disappointing: current gdb is
> unable to handle such breakpoint remotely. There is hope, latest cvs has
> it fixed - but suffers from other regressions which make it unusable for
> kernel debugging. In the meantime, you can still write your own
> "maintenance packet Z2,..." requests. :p
>
> To give an overview of the series:
> Patch 1..3 - Critical debugger fixes for KVM (should be merge in any
> case)
>

Applied 2, 3 (and my version of 1).

> Patch 4..5 - QEMU refactoring, required for following KVM patches, but
> also of generic use for QEMU (rebase and feature
> enhancements are required to get them in shape for
> upstream)
>

These need to go into upstream first, otherwise we're just moving one
patch queue into another.

> Patch 6..8 - New guest debugging interface and SMP support
> Patch 9..11 - Kernel-side changes for new guest debugging interface and
> proper x86 debug register virtualization
>

I'll do a proper review of these, but from a cursory look, all is well.

--
error compiling committee.c: too many arguments to function