From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/11] QEMU/KVM: Fix deadlocks in monitor and debugger Date: Tue, 27 May 2008 12:36:51 +0300 Message-ID: <483BD633.3080302@qumranet.com> References: <4839B14A.3010406@web.de> <483B351E.6010305@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Hollis Blanchard , Jerone Young , Joerg Roedel To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:28054 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755943AbYE0Jgx (ORCPT ); Tue, 27 May 2008 05:36:53 -0400 In-Reply-To: <483B351E.6010305@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Some monitor commands as well as the vm_stop() issued by the gdbstub on > external interruption so far deadlock on vcpu locks in the kernel. Patch > below resolves the issue by temporarily or permanently stopping all vcpu > threads before issuing the related KVM IOCTLs. It enables, e.g., to > break into guest code spinning in the vcpu and to use things like "info > cpus" in the monitor. > I implemented the alternative on_vcpu() approach for this (similar to smp_call_function_single in the kernel) which solves the livelock without resorting to stopping the VM. -- error compiling committee.c: too many arguments to function