From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/11] Rework guest debug interface / x86 debug register support -v2 Date: Tue, 27 May 2008 12:50:20 +0300 Message-ID: <483BD95C.1010309@qumranet.com> References: <4839B14A.3010406@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Hollis Blanchard , Jerone Young , Joerg Roedel To: Jan Kiszka Return-path: Received: from il.qumranet.com ([212.179.150.194]:29816 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755296AbYE0JuV (ORCPT ); Tue, 27 May 2008 05:50:21 -0400 In-Reply-To: <4839B14A.3010406@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Hi, > > here comes the full series of patches to fix and enhance debugging > support of KVM. After completing hardware breakpoint support and > reorganizing the patches, I felt like I should post them all in a single > series, because my queue became quite long and potentially confusing in > the meantime. > > The major changes or this revision are full hardware-assisted guest > debugging and a lot of refactoring on the userspace side. The latter was > motivated by an increasing inconsistency regarding which arch-specific > part should be handled in libkvm and which by qemu. I decided to push > everything into qemu, keeping the lib small (and easier to overcome one > day :->). > > When I was trying to test the hardware breakpoint/watchpoint support > with gdb, the first result with quite disappointing: current gdb is > unable to handle such breakpoint remotely. There is hope, latest cvs has > it fixed - but suffers from other regressions which make it unusable for > kernel debugging. In the meantime, you can still write your own > "maintenance packet Z2,..." requests. :p > > To give an overview of the series: > Patch 1..3 - Critical debugger fixes for KVM (should be merge in any > case) > Applied 2, 3 (and my version of 1). > Patch 4..5 - QEMU refactoring, required for following KVM patches, but > also of generic use for QEMU (rebase and feature > enhancements are required to get them in shape for > upstream) > These need to go into upstream first, otherwise we're just moving one patch queue into another. > Patch 6..8 - New guest debugging interface and SMP support > Patch 9..11 - Kernel-side changes for new guest debugging interface and > proper x86 debug register virtualization > I'll do a proper review of these, but from a cursory look, all is well. -- error compiling committee.c: too many arguments to function