Re: [Patch 6/7] RealMode: Adds support for mov seg, r (0x8e) instruction

[Avi Kivity <avi@qumranet.com>]

Guillaume Thouvenin wrote:
> Adds support for mov r, sreg (0x8c) instruction. 
> We also introduce a table called vcpu_sreg_table[] to avoid an
> unreadable switch. This table is also used to emulate instruction 0X8c. 
>
>  
> +/*
> + * This table is used by instruction like Ox8c to avoid long ugly switch.
> + * The order is important, index is given by c->modrm_reg.
> + */
> +static u16 vcpu_sreg_table[] = {
> +	VCPU_SREG_ES,
> +	VCPU_SREG_CS,
> +	VCPU_SREG_SS,
> +	VCPU_SREG_DS,
> +	VCPU_SREG_FS,
> +	VCPU_SREG_GS,
> +};
> +
>
>   

'static u16' -> 'static const u8'

Also, you can make the ordering explicit:

static const u8 vcpu_sreg_table[] = {
    [0]: VCPU_SREG_ES,
    ...
};


-- 
error compiling committee.c: too many arguments to function