From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [kvm-devel] [PATCH 2/5] SCI fixes (v2)
Date: Tue, 27 May 2008 13:28:34 -0500
Message-ID: <483C52D2.2080603@us.ibm.com>
References: <1202137865-20232-1-git-send-email-aliguori@us.ibm.com> <1202137865-20232-3-git-send-email-aliguori@us.ibm.com> <1211857519.14708.30.camel@bling>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm@vger.kernel.org>, Avi Kivity <avi@qumranet.com>
To: Alex Williamson <alex.williamson@hp.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e2.ny.us.ibm.com ([32.97.182.142]:34533 "EHLO e2.ny.us.ibm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755466AbYE0S2m (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 27 May 2008 14:28:42 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e2.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m4RISg6G000589
	for <kvm@vger.kernel.org>; Tue, 27 May 2008 14:28:42 -0400
Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m4RISgI6154298
	for <kvm@vger.kernel.org>; Tue, 27 May 2008 14:28:42 -0400
Received: from d01av03.pok.ibm.com (loopback [127.0.0.1])
	by d01av03.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m4RISfvC011912
	for <kvm@vger.kernel.org>; Tue, 27 May 2008 14:28:41 -0400
In-Reply-To: <1211857519.14708.30.camel@bling>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Alex Williamson wrote:
> On Mon, 2008-02-04 at 09:11 -0600, Anthony Liguori wrote:
>   
>> @@ -97,11 +100,12 @@ static void pm_update_sci(PIIX4PMState *s)
>>      pmsts = get_pmsts(s);
>>      sci_level = (((pmsts & s->pmen) &
>>                    (RTC_EN | PWRBTN_EN | GBL_EN | TMROF_EN)) != 0);
>> -    qemu_set_irq(s->dev.irq[0], sci_level);
>> +    qemu_set_irq(s->irq, sci_level);
>>      /* schedule a timer interruption if needed */
>>      if ((s->pmen & TMROF_EN) && !(pmsts & TMROF_EN)) {
>>          expire_time = muldiv64(s->tmr_overflow_time, ticks_per_sec, PM_FREQ);
>>          qemu_mod_timer(s->tmr_timer, expire_time);
>> +        s->tmr_overflow_time += 0x800000;
>>     
>
> Hi Anthony,
>
> I'm digging up a patch from a while back.  What's the purpose of bumping
> tmr_overflow_time here?  It seems like this is intended to prevent the
> timer overflow status from ever triggering an SCI, but that seems
> contrary to the ACPI spec.  I've tracked down a case where Vista is
> enabling the timer overflow and appears to get stuck if it never gets
> the overflow interrupt.  Commenting out the last line here fixes it.
> Suggestions?  Thanks,
>   

Avi is the original author of the patch I believe.  Perhaps he can shed 
some light on this?

Regards,

Anthony Liguori

> 	Alex
>
>