From: Avi Kivity <avi@qumranet.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Mohammed Gamal <m.gamal005@gmail.com>,
"Kamble, Nitin A" <nitin.a.kamble@intel.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
laurent.vivier@bull.net, Alexander Graf <alex@csgraf.de>
Subject: Re: [Patch 4/7] RealMode: Adds support for jmp far 0xea
Date: Wed, 28 May 2008 09:30:35 +0300 [thread overview]
Message-ID: <483CFC0B.9040208@qumranet.com> (raw)
In-Reply-To: <483C53C8.6030400@us.ibm.com>
Anthony Liguori wrote:
>> @@ -1661,7 +1662,33 @@ special_insn:
>> break;
>> }
>> case 0xe9: /* jmp rel */
>> - case 0xeb: /* jmp rel short */
>> + goto jmp;
>>
>
> The cases don't have to be in ascending order. Much better to leave
> 0xeb here then have a jmp cross case boundaries.
I find that sorting helps finding opcodes quickly. A simple search
doesn't work due to ranges.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2008-05-28 6:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080527084115.2b0cfae1@frecb000711.frec.bull.fr>
[not found] ` <20080527101923.77e62e21@frecb000711.frec.bull.fr>
2008-05-27 10:12 ` [Patch 6/7] RealMode: Adds support for mov seg, r (0x8e) instruction Avi Kivity
2008-05-27 12:49 ` Guillaume Thouvenin
[not found] ` <20080527101933.68cdc7de@frecb000711.frec.bull.fr>
2008-05-27 10:14 ` [Patch 7/7] RealMode: Adds support for mov r, sreg (0x8c) instruction Avi Kivity
2008-05-27 13:05 ` Guillaume Thouvenin
2008-05-27 13:13 ` Guillaume Thouvenin
[not found] ` <20080527101908.749cff41@frecb000711.frec.bull.fr>
2008-05-27 18:32 ` [Patch 4/7] RealMode: Adds support for jmp far 0xea Anthony Liguori
2008-05-28 6:30 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=483CFC0B.9040208@qumranet.com \
--to=avi@qumranet.com \
--cc=alex@csgraf.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=guillaume.thouvenin@ext.bull.net \
--cc=kvm@vger.kernel.org \
--cc=laurent.vivier@bull.net \
--cc=m.gamal005@gmail.com \
--cc=mtosatti@redhat.com \
--cc=nitin.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox