From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [Patch 4/7] RealMode: Adds support for jmp far 0xea
Date: Wed, 28 May 2008 09:30:35 +0300
Message-ID: <483CFC0B.9040208@qumranet.com>
References: <20080527084115.2b0cfae1@frecb000711.frec.bull.fr> <20080527101908.749cff41@frecb000711.frec.bull.fr> <483C53C8.6030400@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Guillaume Thouvenin <guillaume.thouvenin@ext.bull.net>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	Mohammed Gamal <m.gamal005@gmail.com>,
	"Kamble, Nitin A" <nitin.a.kamble@intel.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, laurent.vivier@bull.net,
	Alexander Graf <alex@csgraf.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:36811 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750978AbYE1Gah (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 28 May 2008 02:30:37 -0400
In-Reply-To: <483C53C8.6030400@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
>> @@ -1661,7 +1662,33 @@ special_insn:
>>          break;
>>      }
>>      case 0xe9: /* jmp rel */
>> -    case 0xeb: /* jmp rel short */
>> +        goto jmp;
>>   
>
> The cases don't have to be in ascending order.  Much better to leave 
> 0xeb here then have a jmp cross case boundaries.

I find that sorting helps finding opcodes quickly.  A simple search 
doesn't work due to ranges.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.