public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Re: KVM: migrate PIT timer
Date: Wed, 28 May 2008 09:34:41 +0300	[thread overview]
Message-ID: <483CFD01.60505@qumranet.com> (raw)
In-Reply-To: <20080527151020.GA9438@dmt>

Marcelo Tosatti wrote:
> On Tue, May 27, 2008 at 04:17:30PM +0300, Avi Kivity wrote:
>   
>> Instead of having two timer bits, how about keeping just on 
>> MIGRATE_TIMER bit which migrates both, and having 
>> __kvm_migrate_pit_timer() return if not on vcpu 0?
>>
>> This can result in shorter code, and in less proliferation of the "pit 
>> is bound to vcpu 0" logic.
>>     
>
> Sure.
>
> Migrate the PIT timer to the physical CPU which vcpu0 is scheduled on,
> similarly to what is done for the LAPIC timers, otherwise PIT interrupts
> will be delayed until an unrelated event causes an exit.
>
>   

Thanks, applied.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


      reply	other threads:[~2008-05-28  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-25  5:29 KVM: migrate PIT timer Marcelo Tosatti
2008-05-27 13:17 ` Avi Kivity
2008-05-27 15:10   ` Marcelo Tosatti
2008-05-28  6:34     ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=483CFD01.60505@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox