From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [patch 01/12] expose ACPI pmtimer to userspace (/dev/pmtimer)
Date: Wed, 04 Jun 2008 12:53:13 +0300
Message-ID: <48466609.8070007@qumranet.com>
References: <20080529222249.563011248@localhost.localdomain> <20080529222828.541115340@localhost.localdomain> <alpine.LFD.1.10.0806011817520.3235@apollo.tec.linutronix.de> <4842D4BB.5020907@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Chris Wright <chrisw@redhat.com>,
	Glauber Costa <gcosta@redhat.com>, kvm@vger.kernel.org,
	john stultz <johnstul@us.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:29090
	"EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752371AbYFDJxK (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Jun 2008 05:53:10 -0400
In-Reply-To: <4842D4BB.5020907@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
> Thomas Gleixner wrote:
>> Can we please keep that code inside of drivers/clocksource/acpi_pm.c
>> without creating a new disconnected file in drivers/char ?
>>
>> Btw, depending on the use case we might as well have a sysfs entry 
>> for that.
>
> I think sysfs would actually make a lot of sense for this.
>

It's read many thousands of times per second.  You don't want a 
read()/sprintf()/atoi() sequence every time.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.