From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] QEMU/KVM: set cpu_single_env before flushing work Date: Wed, 04 Jun 2008 13:03:56 +0300 Message-ID: <4846688C.5060401@qumranet.com> References: <48407117.1090904@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Jerone Young To: Jan Kiszka Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:30585 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753262AbYFDKDy (ORCPT ); Wed, 4 Jun 2008 06:03:54 -0400 In-Reply-To: <48407117.1090904@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > As Jerone pointed out, current kvm_invoke_guest_debug may segfault. The > reason is lacking re-initialization of cpu_single_env before > flush_queued_work is called. Here is the fix. > > Applied, thanks. I also removed the same assignment a few lines later. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.