From: Avi Kivity <avi@qumranet.com>
To: Eli Collins <ecollins@vmware.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Clear CR4.VMXE in hardware_disable
Date: Wed, 04 Jun 2008 13:15:19 +0300 [thread overview]
Message-ID: <48466B37.5040301@qumranet.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806012023270.5992@ecollins-dev1.eng.vmware.com>
Eli Collins wrote:
>
> Clear CR4.VMXE in hardware_disable. There's no reason to leave it set
> after doing a VMXOFF.
>
> VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU
> is in VMX mode, so leaving VMXE set means we'll refuse to power on.
> With this change the user can power on after unloading the kvm-intel
> module. I tested on kvm-67 and kvm-69.
Applied, thanks. The patch was whitespace-mangled though. Did you
cut'n'paste into your email client?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next parent reply other threads:[~2008-06-04 10:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.64.0806012023270.5992@ecollins-dev1.eng.vmware.com>
2008-06-04 10:15 ` Avi Kivity [this message]
2008-06-04 17:34 ` [PATCH] Clear CR4.VMXE in hardware_disable Eli Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48466B37.5040301@qumranet.com \
--to=avi@qumranet.com \
--cc=ecollins@vmware.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox