From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Clear CR4.VMXE in hardware_disable Date: Wed, 04 Jun 2008 13:15:19 +0300 Message-ID: <48466B37.5040301@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Eli Collins Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:32364 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbYFDKPQ (ORCPT ); Wed, 4 Jun 2008 06:15:16 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Eli Collins wrote: > > Clear CR4.VMXE in hardware_disable. There's no reason to leave it set > after doing a VMXOFF. > > VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU > is in VMX mode, so leaving VMXE set means we'll refuse to power on. > With this change the user can power on after unloading the kvm-intel > module. I tested on kvm-67 and kvm-69. Applied, thanks. The patch was whitespace-mangled though. Did you cut'n'paste into your email client? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.