Re: [PATCH] Clear CR4.VMXE in hardware_disable

Re: [PATCH] Clear CR4.VMXE in hardware_disable

[Avi Kivity]

Eli Collins wrote:
>
> Clear CR4.VMXE in hardware_disable. There's no reason to leave it set 
> after doing a VMXOFF.
>
> VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU 
> is in VMX mode, so leaving VMXE set means we'll refuse to power on. 
> With this change the user can power on after unloading the kvm-intel 
> module. I tested on kvm-67 and kvm-69.

Applied, thanks.  The patch was whitespace-mangled though.  Did you 
cut'n'paste into your email client?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.

Re: [PATCH] Clear CR4.VMXE in hardware_disable

[Eli Collins]

On Wed, 4 Jun 2008, Avi Kivity wrote:

> Eli Collins wrote:
>> 
>> Clear CR4.VMXE in hardware_disable. There's no reason to leave it set after 
>> doing a VMXOFF.
>> 
>> VMware Workstation 6.5 checks CR4.VMXE as a proxy for whether the CPU is in 
>> VMX mode, so leaving VMXE set means we'll refuse to power on. With this 
>> change the user can power on after unloading the kvm-intel module. I tested 
>> on kvm-67 and kvm-69.
>
> Applied, thanks.  The patch was whitespace-mangled though.  Did you 
> cut'n'paste into your email client?

Thanks for the heads up. It's probably pine, I need to change some config 
options. I redirected the output of git diff to a file and then used 
pine's read file to include it.

Btw, maybe of interest, I also tested that workstation and kvm-69 play 
nicely on SVM, you can run both simultaneously w/o issue (which was 
expected).

Thanks,
Eli