From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 01/12] expose ACPI pmtimer to userspace (/dev/pmtimer) Date: Wed, 04 Jun 2008 13:35:46 +0300 Message-ID: <48467002.9000002@qumranet.com> References: <20080529222249.563011248@localhost.localdomain> <20080529222828.541115340@localhost.localdomain> <4842D4BB.5020907@codemonkey.ws> <48466609.8070007@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Marcelo Tosatti , Chris Wright , Glauber Costa , kvm@vger.kernel.org, john stultz To: Thomas Gleixner Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:35646 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036AbYFDKhv (ORCPT ); Wed, 4 Jun 2008 06:37:51 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Thomas Gleixner wrote: > On Wed, 4 Jun 2008, Avi Kivity wrote: > >> Anthony Liguori wrote: >> >>> Thomas Gleixner wrote: >>> >>>> Can we please keep that code inside of drivers/clocksource/acpi_pm.c >>>> without creating a new disconnected file in drivers/char ? >>>> >>>> Btw, depending on the use case we might as well have a sysfs entry for >>>> that. >>>> >>> I think sysfs would actually make a lot of sense for this. >>> >>> >> It's read many thousands of times per second. You don't want a >> read()/sprintf()/atoi() sequence every time. >> > > Eek, according to Andrea it's only used for migration purpose. > Oh, right. We also emulate pmtimer in qemu but it shouldn't need to read the host pmtimer. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.