From: Avi Kivity <avi@qumranet.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Zdenek Kabelac <zdenek.kabelac@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: BUG: using smp_processor_id() in preemptible [00000000] code: pm-suspend/17334
Date: Wed, 04 Jun 2008 14:16:31 +0300 [thread overview]
Message-ID: <4846798F.2030002@qumranet.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0806041312070.10085@jikos.suse.cz>
Jiri Kosina wrote:
> On Wed, 4 Jun 2008, Thomas Gleixner wrote:
>
>
>>> OK, so it looks like KVM could be wrongly enabling IRQs/preemption on
>>> the resume path. The original bug-report is on
>>> http://lkml.org/lkml/2008/4/7/130
>>>
>> sysdev_resume() is supposed to run with interrupts disabled, at least
>> it was that way when the timekeeping_resume code was written.
>>
>
> True. However in Zdenek's case, interrupts/preemption gets enabled
> somewhere during the resume, which correctly triggers the warning.
>
>
We might add a check to the generic resume controller, to check after
each ->resume() method and warn in case of interrupts enabled. That
will pinpoint the offending driver immediately.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
prev parent reply other threads:[~2008-06-04 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <c4e36d110806030142j379f5a63xfba7c3bbb9df602a@mail.gmail.com>
[not found] ` <Pine.LNX.4.64.0806031350330.1716@twin.jikos.cz>
[not found] ` <c4e36d110806030501g46363beev7126c8312aadd12e@mail.gmail.com>
2008-06-03 12:05 ` BUG: using smp_processor_id() in preemptible [00000000] code: pm-suspend/17334 Jiri Kosina
2008-06-04 9:41 ` Avi Kivity
2008-06-04 9:57 ` Zdenek Kabelac
2008-06-04 10:34 ` Avi Kivity
2008-06-04 10:54 ` Thomas Gleixner
2008-06-04 11:13 ` Jiri Kosina
2008-06-04 11:16 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4846798F.2030002@qumranet.com \
--to=avi@qumranet.com \
--cc=jkosina@suse.cz \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox