From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest Date: Wed, 04 Jun 2008 17:19:21 +0300 Message-ID: <4846A469.4020009@qumranet.com> References: <1212389189-26115-1-git-send-email-amit.shah@qumranet.com> <08DF4D958216244799FC84F3514D70F00172DB36@pdsmsx415.ccr.corp.intel.com> <200806021341.23106.amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Han, Weidong" , kvm@vger.kernel.org, muli@il.ibm.com, benami@il.ibm.com, "Kay, Allen M" , chrisw@redhat.com To: Amit Shah Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:17921 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752892AbYFDOTS (ORCPT ); Wed, 4 Jun 2008 10:19:18 -0400 In-Reply-To: <200806021341.23106.amit.shah@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > The first option can be enforced by calls to pci_enable_device() and > pci_request_regions(). This can solve the problem of assigning multiple > devices of the same guest as well. > Yes, that sounds good. > Dynamically unbinding devices is prone to a lot of errors and assumptions and > such policy shouldn't be enforced. We should either fail the assignment and > let the administrator take care of doing the right thing and start the guest > or just not launch the guest at all. > Agreed. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.