From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] KVM/userspace: Support for assigning PCI devices to guest Date: Wed, 04 Jun 2008 17:53:53 +0300 Message-ID: <4846AC81.5090304@qumranet.com> References: <1212389189-26115-1-git-send-email-amit.shah@qumranet.com> <200806021341.23106.amit.shah@qumranet.com> <4846A469.4020009@qumranet.com> <200806042013.29968.amit.shah@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Han, Weidong" , kvm@vger.kernel.org, muli@il.ibm.com, benami@il.ibm.com, "Kay, Allen M" , chrisw@redhat.com To: Amit Shah Return-path: Received: from bzq-179-150-194.static.bezeqint.net ([212.179.150.194]:22539 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbYFDOxu (ORCPT ); Wed, 4 Jun 2008 10:53:50 -0400 In-Reply-To: <200806042013.29968.amit.shah@qumranet.com> Sender: kvm-owner@vger.kernel.org List-ID: Amit Shah wrote: > I was thinking of putting the device in "suspend" state. However, I checked a > few drivers and not all release resources during suspend. However, even if > this is possible, it becomes an enforced policy that a user may not like. > What happens if there is a real suspend? The right thing is for kvm to claim the device. It's conceptually the right thing; kvm _is_ the device driver for that device, through the guest it is running. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.