Re: [PATCH 0/5] kvm: Batch writes to MMIO

Laurent Vivier
2008-05-26T12:10:28Z

Le lundi 26 mai 2008 à 15:00 +0300, Avi Kivity a écrit :
> Laurent Vivier wrote:
> > When kernel has to send MMIO writes to userspace, it stores them
> > in memory until it has to pass the hand to userspace for another
> > reason. This avoids to have too many context switches on operations
> > that can wait.
> >
> >
>
> Looks good. The only issue I see is inconsistent naming. Sometimes you
> use delayed_mmio, sometimes batched_mmio, and there's a way-too-generic
> kvm_batch. Please stick to a single name throughout the code.

Which is your favorite ?

> > VGA text scroll
> > host_state_reload 13280568 (6:15) 3608362 (4:42) -73% (-25%)
>
> This is probably better addressed by allowing the guest to write
> directly to VRAM, like in the graphic modes.

Should I modify something in the patch ?

Thank you for your comments.

Regards,
Laurent
--
------------- Laurent.Vivier@bull.net ---------------
"The best way to predict the future is to invent it."
- Alan Kay