From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 1/2] KVM: consolidate check for pending vcpu requests Date: Sun, 08 Jun 2008 10:10:16 +0300 Message-ID: <484B85D8.1080908@qumranet.com> References: <20080606193734.495417169@localhost.localdomain> <20080606194010.897342530@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Chris Wright , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from il.qumranet.com ([212.179.150.194]:48262 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753795AbYFHHKT (ORCPT ); Sun, 8 Jun 2008 03:10:19 -0400 In-Reply-To: <20080606194010.897342530@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Marcelo Tosatti wrote: > A guest vcpu instance can be scheduled to a different physical CPU > between the test for KVM_REQ_MIGRATE_TIMER and local_irq_disable(). > > If that happens, the timer will only be migrated to the current pCPU on > the next exit, meaning that guest LAPIC timer event can be delayed until > a host interrupt is triggered. > > Fix it by cancelling guest entry if any vcpu request is pending. > Applied, thanks. -- error compiling committee.c: too many arguments to function