From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] fix destroying a userspace physical memory slot Date: Sun, 08 Jun 2008 13:31:30 +0300 Message-ID: <484BB502.7020902@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Muli Ben-Yehuda , Amit Shah To: Ben-Ami Yassour Return-path: Received: from il.qumranet.com ([212.179.150.194]:16417 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756878AbYFHKbc (ORCPT ); Sun, 8 Jun 2008 06:31:32 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Ben-Ami Yassour wrote: > Avi, > > This patch fixes the destruction path of a userspace physical memory > slot, which is required for direct mmio for passthrough devices. > The problem was that the destruction was done by calling > kvm_create_phys_mem with length 0. > kvm_create_phys_mem was calling kvm_create_userspace_phys_mem, which > calls mmap with lenght 0, which failed. > This patch applies to the main kvm userspace tree. > The patch was tested with direct mmio using the pci-passthrough tree. Looks good, but doesn't apply. Please check your mail client's whitespace mangling settings (or post as attachment). -- error compiling committee.c: too many arguments to function