From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] do not use extra env field.
Date: Mon, 09 Jun 2008 19:02:52 +0300
Message-ID: <484D542C.2040708@qumranet.com>
References: <1212719787-10758-1-git-send-email-gcosta@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, glommer@gmail.com
To: Glauber Costa <gcosta@redhat.com>,
	"Xu, Anthony" <anthony.xu@intel.com>,
	"Zhang, Xiantao" <xiantao.zhang@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:14770 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751385AbYFIQCq (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 9 Jun 2008 12:02:46 -0400
In-Reply-To: <1212719787-10758-1-git-send-email-gcosta@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Glauber Costa wrote:
> There's no need to polute the already poluted CPUState
> with "ready_for_interrupt_injection". We can compute it
> in the few times we use it, and be fine.
>   

>  #define CPUState CPUIA64State
> diff --git a/qemu/target-ia64/op_helper.c b/qemu/target-ia64/op_helper.c
> index 4969ef7..f582023 100644
> --- a/qemu/target-ia64/op_helper.c
> +++ b/qemu/target-ia64/op_helper.c
> @@ -36,7 +36,6 @@ CPUState *cpu_ia64_init(char *cpu_model){
>      cpu_reset(env);
>      if (kvm_enabled()) {
>  	kvm_qemu_init_env(env);
> -	env->ready_for_interrupt_injection = 1;
>  	kvm_init_new_ap(env->cpu_index, env);
>      }
>      return env;
>   

This bit means that this patch is not an identity transformation.  
Anthony/Xiantao, can you confirm that this patch is safe for ia64?

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.