From: Gerd Hoffmann <kraxel@redhat.com>
To: Avi Kivity <avi@qumranet.com>
Cc: kvm@vger.kernel.org
Subject: Re: Oops for sale
Date: Mon, 09 Jun 2008 18:54:01 +0200 [thread overview]
Message-ID: <484D6029.1020209@redhat.com> (raw)
In-Reply-To: <484D5B4F.3080300@qumranet.com>
Avi Kivity wrote:
> The unshadow-on-userspace-access heuristic is broken. Since it is also
> bad for Xenner, try removing the following lines:
>
> spte |= PT_WRITABLE_MASK;
Well, that line should better not be removed. I get a hang otherwise,
guess due to running into a page-fault loop ...
> if (user_fault) {
> mmu_unshadow(vcpu->kvm, gfn);
> goto unshadowed;
> }
Deactivating those four lines fixed it.
thanks,
Gerd
--
http://kraxel.fedorapeople.org/xenner/
next prev parent reply other threads:[~2008-06-09 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 14:01 Oops for sale Gerd Hoffmann
2008-06-06 20:48 ` Avi Kivity
[not found] ` <484D3310.6070908@redhat.com>
2008-06-09 16:33 ` Avi Kivity
2008-06-09 16:54 ` Gerd Hoffmann [this message]
2008-06-11 3:02 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=484D6029.1020209@redhat.com \
--to=kraxel@redhat.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox