From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 2/11] QEMU/KVM: Cleanup and improve kvm_load/save_registers usage Date: Mon, 09 Jun 2008 14:16:10 -0500 Message-ID: <484D817A.7040204@codemonkey.ws> References: <4839B14A.3010406@web.de> <483B3525.4010100@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm-devel , Avi Kivity , Hollis Blanchard , Jerone Young , Joerg Roedel To: Jan Kiszka Return-path: Received: from yx-out-2324.google.com ([74.125.44.28]:48456 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752441AbYFITQj (ORCPT ); Mon, 9 Jun 2008 15:16:39 -0400 Received: by yx-out-2324.google.com with SMTP id 31so221316yxl.1 for ; Mon, 09 Jun 2008 12:16:38 -0700 (PDT) In-Reply-To: <483B3525.4010100@web.de> Sender: kvm-owner@vger.kernel.org List-ID: Jan Kiszka wrote: > Remove redundant checkes for kvm_enabled() on register updates between > userspace and kvm kernel driver. Ensure register update across all CPUs > on "info cpus" monitor command. > This breaks the build when KVM is disabled. The explicit guard is needed to avoid having #ifdefs. Please revert. Regards, Anthony Liguori > Signed-off-by: Jan Kiszka > --- > qemu/gdbstub.c | 12 ++++-------- > qemu/monitor.c | 4 ++-- > 2 files changed, 6 insertions(+), 10 deletions(-) > > Index: b/qemu/monitor.c > =================================================================== > --- a/qemu/monitor.c > +++ b/qemu/monitor.c > @@ -286,8 +286,7 @@ static CPUState *mon_get_cpu(void) > mon_set_cpu(0); > } > > - if (kvm_enabled()) > - kvm_save_registers(mon_cpu); > + kvm_save_registers(mon_cpu); > > return mon_cpu; > } > @@ -315,6 +314,7 @@ static void do_info_cpus(void) > mon_get_cpu(); > > for(env = first_cpu; env != NULL; env = env->next_cpu) { > + kvm_save_registers(env); > term_printf("%c CPU #%d:", > (env == mon_cpu) ? '*' : ' ', > env->cpu_index); > Index: b/qemu/gdbstub.c > =================================================================== > --- a/qemu/gdbstub.c > +++ b/qemu/gdbstub.c > @@ -904,8 +904,7 @@ static int gdb_handle_packet(GDBState *s > addr = strtoull(p, (char **)&p, 16); > #if defined(TARGET_I386) > env->eip = addr; > - if (kvm_enabled()) > - kvm_load_registers(env); > + kvm_load_registers(env); > #elif defined (TARGET_PPC) > env->nip = addr; > #elif defined (TARGET_SPARC) > @@ -928,8 +927,7 @@ static int gdb_handle_packet(GDBState *s > addr = strtoull(p, (char **)&p, 16); > #if defined(TARGET_I386) > env->eip = addr; > - if (kvm_enabled()) > - kvm_load_registers(env); > + kvm_load_registers(env); > #elif defined (TARGET_PPC) > env->nip = addr; > #elif defined (TARGET_SPARC) > @@ -973,8 +971,7 @@ static int gdb_handle_packet(GDBState *s > } > break; > case 'g': > - if (kvm_enabled()) > - kvm_save_registers(env); > + kvm_save_registers(env); > reg_size = cpu_gdb_read_registers(env, mem_buf); > memtohex(buf, mem_buf, reg_size); > put_packet(s, buf); > @@ -984,8 +981,7 @@ static int gdb_handle_packet(GDBState *s > len = strlen(p) / 2; > hextomem((uint8_t *)registers, p, len); > cpu_gdb_write_registers(env, mem_buf, len); > - if (kvm_enabled()) > - kvm_load_registers(env); > + kvm_load_registers(env); > put_packet(s, "OK"); > break; > case 'm': > > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >