From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH 2/11] QEMU/KVM: Cleanup and improve kvm_load/save_registers
 usage
Date: Thu, 12 Jun 2008 15:38:11 +0300
Message-ID: <485118B3.4090509@qumranet.com>
References: <4839B14A.3010406@web.de> <483B3525.4010100@web.de> <484D817A.7040204@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Jan Kiszka <jan.kiszka@web.de>, kvm-devel <kvm@vger.kernel.org>,
	Hollis Blanchard <hollisb@us.ibm.com>,
	Jerone Young <jyoung5@us.ibm.com>,
	Joerg Roedel <joerg.roedel@amd.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Return-path: <kvm-owner@vger.kernel.org>
Received: from il.qumranet.com ([212.179.150.194]:43371 "EHLO il.qumranet.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752671AbYFLMkT (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 12 Jun 2008 08:40:19 -0400
In-Reply-To: <484D817A.7040204@codemonkey.ws>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Anthony Liguori wrote:
> Jan Kiszka wrote:
>> Remove redundant checkes for kvm_enabled() on register updates between
>> userspace and kvm kernel driver. Ensure register update across all CPUs
>> on "info cpus" monitor command.
>>   
>
> This breaks the build when KVM is disabled.  The explicit guard is 
> needed to avoid having #ifdefs.  Please revert.
>

You mean a link time error?  Well in that case we're relying on gcc 
optimizing away the call.  It will break with -O0.

The correct fix is to define stubs for the case kvm is configured out 
(or just use ifdefs).  But perhaps Glauber's accelerator framework will 
take care of all this in a generic fashion.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.